Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding accessors to AccessGlobal and AccessIntsanceGlobal #144

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

lucaneg
Copy link
Member

@lucaneg lucaneg commented Oct 29, 2021

Description
Classes AccessGlobal and AccessInstanceGlobal miss accessors to their target and other relevant fields. This pull request adds these accessors.

Fixed bugs
Closes #143

@lucaneg lucaneg added the 🐛 type:bug Something isn't working label Oct 29, 2021
@lucaneg lucaneg added this to the 0.1b3 milestone Oct 29, 2021
@lucaneg lucaneg self-assigned this Oct 29, 2021
@lucaneg lucaneg added the 🏗 resolution:wip Incomplete work - do not review yet label Oct 29, 2021
@github-actions
Copy link

Unit Test Results

  33 files    33 suites   9s ⏱️
204 tests 204 ✔️ 0 💤 0 ❌

Results for commit 5033ab1.

@lucaneg lucaneg removed the 🏗 resolution:wip Incomplete work - do not review yet label Oct 29, 2021
@github-actions

This comment has been minimized.

@VincenzoArceri VincenzoArceri merged commit 19aa163 into master Oct 29, 2021
@VincenzoArceri VincenzoArceri deleted the access-global-accessors branch October 29, 2021 15:49
@github-actions
Copy link

All Test Results (unit + cron)

  43 files  ±0    43 suites  ±0   14s ⏱️ +2s
226 tests ±0  226 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 19aa163. ± Comparison against base commit 0dd4d46.

@lucaneg lucaneg added the 🏛 scope:program-structure Work regarding the program structure label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛 scope:program-structure Work regarding the program structure 🐛 type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing accessors in AccessGlobal and AccessInstanceGlobal
2 participants