-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always detecting ElasticSearch in LXC as service to restart #54
Comments
Also checked with current master, it's still a problem:
|
Which filesystem is used inside the container (stacked ones)? The interpreter stuff compares the start time of the process 8496 with the modification time of the mapped jar files and detects that the jar files have been modified after launching process 8496 for some reason. |
I think it's just a bind mount of the host's ext4. Stat from inside the container:
Stat from the outside:
|
Oh my, I have different timezones inside and outside the container. But it's already long past last modification, and I've restarted the container today. |
Could you please provide |
Outside:
Outside, as root:
Inside:
|
Hi, I'm still unable to reproduce this issue. Did you try to run needrestart inside your container? The problem seems not to be triggered by the /proc/$PID/stat entries. Could you please provide the output of this small perl cli call from inside and outside of the container?
(The PID assignment needs to be adapted to match the correct process ID inside/outside) |
Outside:
Inside (I've had to install libproc-processtable-perl for it to run):
|
Thanks for your continous feedback. I thought it was a bug somewhere in the interpretation of process creation time and the java class file timestamps. I was wrong, the bug was how needrestart did access interpreter files. It does ignore /proc/$PID/root completely and if the elasticsearch class files are not present outside the container needrestart will always suggest to restart the container due to elasticsearch. |
I'm happy to provide as much feedback as needed, I'm the one with a problem ;-) I've just restarted the problematic container (just to be sure), did a |
Only the new |
Thank you, it works! I've just checked with the 0pre1 package, and it did not report the elasticsearch container as needing restart until I've touched one of the jars ^_^ |
@liske I'm running into this same bug in multiple KVM VM. I'm running Debian jessie currently, any chance of getting this fix into j-bp? Soon? This would be really really great! |
@liske Hm..I'm running |
Please open another issue include verbose logs if the problem still exists. |
I've just restarted the container, but I'm still getting:
The text was updated successfully, but these errors were encountered: