Openmetrics for prometheus #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 28, 2024 18:08
(Implements part of the solution for liske#310)
Apparently, prometheus does not implement the full OpenMetrics spec and only supports a very limited set of metric types. If the output in OpenMetrics format is going to be useful to people, we need the output to be ingestible by prometheus since it's one of the most popular openmetrics-type TSDB software. * type info is trivially converted into a gauge * stateset needs to be reworked into a gauge that has a label that changes to indicate the status This patch also moves the logic about how status codes are interpreted up closer to where they are being used. It keeps the output section easier to read.
anarcat
reviewed
Aug 29, 2024
needrestart
Outdated
Comment on lines
1458
to
1461
| print "needrestart_kernel_status{needrestart_kernel_status=\"$ometric_kernel_values{kresult}\"} 1\n"; | ||
| print "# TYPE needrestart_kernel gauge\n"; | ||
| print "# HELP needrestart_kernel version information for currenly running and most up to date kernels\n"; | ||
| print "needrestart_kernel_info{running=\"$ometric_kernel_values{krunning}\",expected=\"$ometric_kernel_values{kexpected}\"} 1\n"; | ||
| print "needrestart_kernel{running=\"$ometric_kernel_values{krunning}\",expected=\"$ometric_kernel_values{kexpected}\"} 1\n"; |
There was a problem hiding this comment.
any reason why you get rid of the _info suffix? I understand the type info is not supported, but it's a well-established convention to name those _info, that i would retain here.
Naturally, there's a discordance here between the comment and the actual metric that needs to be fixed regardless, but I would go the other way, if only to harmonize with needrestart_build_info...
There was a problem hiding this comment.
hmm you're right, I should keep those. I'll update just now
The types were changed to gauge but functionally they are still used as an info-type metric.
anarcat
approved these changes
Aug 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here have been tested with prometheus to make sure that they work properly