Fix inherit from constructor chain #468
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #467
Instead of checking 'current' constructor level only, this checks the whole constructor chain for
static get styles
. In this way, it never missesstyles
defined on constructors never 'ran' before (like mixins): https://stackblitz.com/edit/lit-element-request-update-bug-lspgdq?file=test.jsThis could however mean that this._styles is created redundantly for constructor layers that should have the same outcome as their parents(and therefore should be able tor reuse
this._styles
). A code example that addresses this problem can be found here:https://github.com/tlouisse/lit-element/blob/fix/getStylesFromConstructorChainAlternative/src/lit-element.ts#L92
But I'm not sure if this is more performant and outweighs the benefits of less code.
Let me know what you think :)