Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1551, Prevent releasing the exclusive lock twice on rebuild. #1554

Closed
wants to merge 1 commit into from
Closed

Conversation

bmallin
Copy link

@bmallin bmallin commented Mar 11, 2020

Since mustExit is never set to false, the finally block will always attempt to release the lock. This is fixed by simply setting mustExit to false if we release the lock before executing the finally block.

@JensSchadron
Copy link
Contributor

Hi @bmallin, thank you for your contribution. It's very much appreciated.
However, sadly, we'll have to decline it as the code in which the fix has been made has been changed once more as part of a rework of the transaction system. See PR #1560 🙂 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants