-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for on-the-fly document upgrades #2489
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
25b0940
Add support for on-the-fly document upgrades
JKamsker 02e23d9
Add deserialization hook to bsonmapper
JKamsker 0fa5d35
Fix indentation of csproj
JKamsker d417e10
Update LiteDB/LiteDB.csproj
JKamsker 1517f66
Merge branch 'master' into ReadTransform
JKamsker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,133 @@ | ||
using FluentAssertions; | ||
|
||
using LiteDB.Engine; | ||
|
||
using System.IO; | ||
|
||
using Xunit; | ||
|
||
namespace LiteDB.Tests.Database; | ||
|
||
public class DocumentUpgrade_Tests | ||
{ | ||
[Fact] | ||
public void DocumentUpgrade_Test() | ||
{ | ||
var ms = new MemoryStream(); | ||
using (var db = new LiteDatabase(ms)) | ||
{ | ||
var col = db.GetCollection("col"); | ||
|
||
col.Insert(new BsonDocument { ["version"] = 1, ["_id"] = 1, ["name"] = "John" }); | ||
} | ||
|
||
ms.Position = 0; | ||
|
||
using (var db = new LiteDatabase(ms)) | ||
{ | ||
var col = db.GetCollection("col"); | ||
|
||
col.Count().Should().Be(1); | ||
|
||
var doc = col.FindById(1); | ||
|
||
doc["version"].AsInt32.Should().Be(1); | ||
doc["name"].AsString.Should().Be("John"); | ||
doc["age"].AsInt32.Should().Be(0); | ||
} | ||
|
||
ms.Position = 0; | ||
|
||
using var engine = new LiteEngine(new EngineSettings | ||
{ | ||
DataStream = ms, | ||
ReadTransform = (collectionName, val) => | ||
{ | ||
if (val is not BsonDocument doc) | ||
{ | ||
return val; | ||
} | ||
|
||
if (doc.TryGetValue("version", out var version) && version.AsInt32 == 1) | ||
{ | ||
doc["version"] = 2; | ||
doc["age"] = 30; | ||
} | ||
|
||
return val; | ||
} | ||
}); | ||
|
||
using (var db = new LiteDatabase(engine)) | ||
{ | ||
var col = db.GetCollection("col"); | ||
|
||
col.Count().Should().Be(1); | ||
|
||
var doc = col.FindById(1); | ||
|
||
doc["version"].AsInt32.Should().Be(2); | ||
doc["name"].AsString.Should().Be("John"); | ||
doc["age"].AsInt32.Should().Be(30); | ||
} | ||
} | ||
|
||
[Fact] | ||
public void DocumentUpgrade_BsonMapper_Test() | ||
{ | ||
var ms = new MemoryStream(); | ||
using (var db = new LiteDatabase(ms)) | ||
{ | ||
var col = db.GetCollection("col"); | ||
|
||
col.Insert(new BsonDocument { ["version"] = 1, ["_id"] = 1, ["name"] = "John" }); | ||
} | ||
|
||
ms.Position = 0; | ||
|
||
using (var db = new LiteDatabase(ms)) | ||
{ | ||
var col = db.GetCollection("col"); | ||
|
||
col.Count().Should().Be(1); | ||
|
||
var doc = col.FindById(1); | ||
|
||
doc["version"].AsInt32.Should().Be(1); | ||
doc["name"].AsString.Should().Be("John"); | ||
doc["age"].AsInt32.Should().Be(0); | ||
} | ||
|
||
ms.Position = 0; | ||
|
||
var mapper = new BsonMapper(); | ||
mapper.OnDeserialization = (sender, type, val) => | ||
{ | ||
if (val is not BsonDocument doc) | ||
{ | ||
return val; | ||
} | ||
|
||
if (doc.TryGetValue("version", out var version) && version.AsInt32 == 1) | ||
{ | ||
doc["version"] = 2; | ||
doc["age"] = 30; | ||
} | ||
|
||
return doc; | ||
}; | ||
|
||
using (var db = new LiteDatabase(ms, mapper)) | ||
{ | ||
var col = db.GetCollection("col"); | ||
|
||
col.Count().Should().Be(1); | ||
|
||
var doc = col.FindById(1); | ||
|
||
doc["version"].AsInt32.Should().Be(2); | ||
doc["name"].AsString.Should().Be("John"); | ||
doc["age"].AsInt32.Should().Be(30); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep consicise with all code base, let's use "this." for instance methods, properties and public fields (only private _ name has no "this.")