Narrow exports of shared libraries #371
Open
+215
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not perform transitive link to boringssl though.
|
Can you please update the pull request to resolve the conflicts. thanks! |
|
Yeah, will do. The one question I do have is about the tests - many of them link against what are probably "implementation details". Do we just want to skip those tests when doing a shared library build? The alternative is manually re-adding the particular source files to each test, which I got some progress on but which is super tedious, or just also building a static version for the tests. |
|
Those tests are intended to test the internals, need to access some internal functions. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #370 .
I'm working on packaging for vcpkg (see microsoft/vcpkg#24310 ) and I noticed that their maintainer guide recommends not allowing Windows shared library builds for libraries with CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS. I thought it would be easy to add export declarations, since there's a clear separate API header. However, it turns out that several examples and tests use nominally "internal" APIs, so in most cases I added additional export defines just to highlight those semi-public APIs. (One usage of a private API is called out in a comment, so that build I just disabled when building for shared libraries).
Curious what you would like to do about those. We could also go to a linker version script/.def file instead of the defines if you prefer. This is mostly a request-for-comment, though I certainly wouldn't mind if it got merged.