Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set model response to NOT prefer alias #2150

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

gsakkis
Copy link
Contributor

@gsakkis gsakkis commented Aug 11, 2023

Pull Request Checklist

  • New code has 100% test coverage

Description

As brought up on Discord few weeks ago, the generated OpenAPI schema should agree with the actual response for aliased Pydantic fields but it doesn't since this change.

@gsakkis gsakkis requested review from a team as code owners August 11, 2023 23:22
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2150

@Goldziher Goldziher changed the title Fix: set model response to NOT prefer alias fix: set model response to NOT prefer alias Aug 12, 2023
@Goldziher Goldziher merged commit edbe1c9 into main Aug 12, 2023
18 of 19 checks passed
@Goldziher Goldziher deleted the dont-prefer-alias-for-response branch August 12, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants