feat: use lambda_stmt in the repository (Sourcery refactored)
#2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
sourcery-ai
bot
force-pushed
the
sourcery/sqla-lambda-stmt
branch
3 times, most recently
from
a8330a8
to
799bbe4
Compare
sourcery-ai
bot
force-pushed
the
sourcery/sqla-lambda-stmt
branch
from
799bbe4
to
64e25de
Compare
| if statement is None: | ||
| return self.statement | ||
| return statement | ||
| return self.statement if statement is None else statement |
There was a problem hiding this comment.
Function SQLAlchemyAsyncRepository._to_lambda_stmt refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| if statement is None: | ||
| return self.statement | ||
| return statement | ||
| return self.statement if statement is None else statement |
There was a problem hiding this comment.
Function SQLAlchemySyncRepository._to_lambda_stmt refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
cofin
added a commit
that referenced
this pull request
Aug 23, 2023
* feat: use `lambda_stmt` in the repository * fix: additional tests are now passing * fix: non-mocked tests are now passing * fix: fix updated remaining tests for lambda_stmt * feat: use `lambda_stmt` in the repository (Sourcery refactored) (#2180) 'Refactored by Sourcery' Co-authored-by: Sourcery AI <> * docs: update * fix: updated syntax * fix: remove debug print * fix: cleanup error handling and remove 23c for now * fix: correctly call method * chore: pre-commit linting * docs: typo correction * docs: adjusted information on SQL Alchemy field types * Update litestar/contrib/sqlalchemy/repository/_async.py Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de> * fix: updated fx call * feat: make delete_many a lambda_stmt * feat: lambdafiy update many * fix: remove `self` reference from lambda * fix: re-add `update` statement * fix: revert signature change * chore: linting * feat(sqlalchemy): adds override for forcing basic paginated query mode (#2200) feat: adds override for forcing basic paginated query mode --------- Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #2179 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
sqla-lambda-stmtbranch, then run:Help us improve this pull request!