Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(response): remove encoded_headers default value #2364

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

provinzkraut
Copy link
Member

@provinzkraut provinzkraut commented Sep 25, 2023

Remove the default value for encoded_headers in Response.to_asgi_response, that resulted in a DeprecationWarning always being raised.

Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
@provinzkraut provinzkraut requested review from a team as code owners September 25, 2023 17:40
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@provinzkraut provinzkraut enabled auto-merge (squash) September 25, 2023 17:46
@provinzkraut provinzkraut merged commit 0e71d27 into main Sep 25, 2023
17 checks passed
@provinzkraut provinzkraut deleted the fix-encoded-headers-warning branch September 25, 2023 17:46
@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants