Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): remove stale hooks #2375 #2377

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix(docs): remove stale hooks #2375 #2377

merged 2 commits into from
Sep 28, 2023

Conversation

JacobCoffee
Copy link
Member

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

  • Remove old lifecycle hooks

Close Issue(s)

@JacobCoffee JacobCoffee requested review from a team as code owners September 27, 2023 23:49
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2377

peterschutt
peterschutt approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@peterschutt peterschutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch with the doc string!

@peterschutt peterschutt merged commit 062092b into main Sep 28, 2023
17 checks passed
@peterschutt peterschutt deleted the 2375_docs_fix_stale_lifecycle_hooks branch September 28, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschutt peterschutt peterschutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: stale chart for lifecycle hooks
2 participants
@JacobCoffee @peterschutt