fix: logging middleware with multi-body response #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/middleware
peterschutt
commented
May 8, 2024
peterschutt
force-pushed
the
3477-logging-mw-multi-body
branch
from
dbc98b8
to
b6010f0
Compare
Prevent logging middleware from failing with a KeyError when a response sends multiple "http.response.body" messages. Closes #3477
peterschutt
force-pushed
the
3477-logging-mw-multi-body
branch
from
7fad639
to
2c26a64
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3478 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 328 328
Lines 14874 14876 +2
Branches 2360 2361 +1
=======================================
+ Hits 14621 14623 +2
Misses 116 116
Partials 137 137 ☔ View full report in Codecov by Sentry. |
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3478 |
JacobCoffee
approved these changes
May 8, 2024
provinzkraut
approved these changes
May 8, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent logging middleware from failing with a KeyError when a response sends multiple "http.response.body" messages.
Closes #3477
Description
Closes