Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): Don't require annotated_types #3750

Merged
merged 1 commit into from
Sep 21, 2024
Merged

fix(typing): Don't require annotated_types #3750

merged 1 commit into from
Sep 21, 2024

Conversation

provinzkraut
Copy link
Member

@provinzkraut provinzkraut commented Sep 21, 2024

Fix a bug introduced in #3721 that was released with 2.12.0 and would cause an ImportError when the annotated_types package was not installed.

Fixes #3749

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (06efa69) to head (d1df71d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3750   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         331      331           
  Lines       15275    15277    +2     
  Branches     2445     2445           
=======================================
+ Hits        15023    15025    +2     
  Misses        112      112           
  Partials      140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 21, 2024

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3750

@provinzkraut provinzkraut merged commit 658350b into main Sep 21, 2024
26 checks passed
@provinzkraut provinzkraut deleted the fix/3749 branch September 21, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ModuleNotFoundError: No module named 'annotated_types'
2 participants