Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Edge.js always return a browser object #18

Merged
merged 1 commit into from
Nov 10, 2016
Merged

Make Edge.js always return a browser object #18

merged 1 commit into from
Nov 10, 2016

Conversation

gkatsev
Copy link
Contributor

@gkatsev gkatsev commented Nov 8, 2016

This makes it line up with the other browser files and fixes #17.

@gkatsev
Make Edge.js always return a browser object
bd36623 
This makes it line up with the other browser files and fixes litixsoft#17.
@fanatid
Copy link

fanatid commented Nov 8, 2016

ACK
please release patch version with this PR

@fanatid fanatid mentioned this pull request Nov 8, 2016
Closed
@nickserv
Copy link
Contributor

nickserv commented Nov 9, 2016 •
edited
Loading

Ultimately resolve is a buggy dependency that isn't properly tested on recent Node versions, but this is a great temporary fix and it should be merged as soon as possible.

nickserv referenced this pull request Nov 9, 2016
@LitixThomas
fix: Issue #17
fbaf966
@LitixThomas LitixThomas merged commit bd36623 into litixsoft:master Nov 10, 2016
@gkatsev gkatsev deleted the patch-1 branch November 10, 2016 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin fails on systems w/o Edge
4 participants
@gkatsev @fanatid @nickserv @LitixThomas