don't keep state in OAuth1Service #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 2.6 doesn't have unittest.TestCase.assertIsNotNone, among others. If we don't have it, try to import unittest2 as unittest.
We can't keep state, because this service object is likely shared across many different uses (and people) -- if an access token is cached, it might be reused by another user who is trying to get a request token.
|
Can you break up these commits? Session problems don't depend on unittest2. :) |
|
You want them in separate pull requests? |
|
Actually I'm just going to rollback that module. It's easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't keep state for things like access_tokens because the service is designed to be a singleton used potentially by many different users with different access_tokens and in different steps of the OAuth process.