-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload file bug with oauth signing was fixed #174
base: master
Are you sure you want to change the base?
Conversation
It was a mistake to set content-type = application/x-www-form-urlencoded by default, requests lib setup it dynamically if we have non-empty parameter "files". Original version didn't work with images (files) upload for example in Etsy API see https://www.etsy.com/developers/documentation/getting_started/images
This isn't passing tests:
|
Still not passing due to:
Also Github does not send notifications when PRs are updated, so please make a comment when this is ready to merge so I get an alert. |
I've just changed format and push changes to repository. So please check it. |
Still failing:
You may want to run tests locally via tox or some other runner. Also you can check TravisCI for build failures. |
I don't know what to do, It works for me. |
Are you running the tests with tox? |
I don't use tox. |
How are you running the tests? It seems like it's not compatible with the Travis runner. |
I'm not running any tests. I fixed only one line. It works. |
It looks like the tests still aren't passing on Travis. More formatting errors. |
It was a mistake to set content-type = application/x-www-form-urlencoded by default, requests lib setup it dynamically if we have non-empty parameter "files".
Original version didn't work with images (files) upload for example in Etsy API see https://www.etsy.com/developers/documentation/getting_started/images