Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload file bug with oauth signing was fixed #174

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nickspring
Copy link

It was a mistake to set content-type = application/x-www-form-urlencoded by default, requests lib setup it dynamically if we have non-empty parameter "files".

Original version didn't work with images (files) upload for example in Etsy API see https://www.etsy.com/developers/documentation/getting_started/images

It was a mistake to set content-type = application/x-www-form-urlencoded by default, requests lib setup it dynamically if we have non-empty parameter "files". 

Original version didn't work with images (files) upload for example in Etsy API see https://www.etsy.com/developers/documentation/getting_started/images
@maxcountryman
Copy link
Contributor

This isn't passing tests:

rauth/session.py:152:80: E501 line too long (86 > 79 characters)

@maxcountryman
Copy link
Contributor

Still not passing due to:

rauth/session.py:153:13: E125 continuation line with same indent as next logical line

Also Github does not send notifications when PRs are updated, so please make a comment when this is ready to merge so I get an alert.

@nickspring
Copy link
Author

I've just changed format and push changes to repository. So please check it.

@maxcountryman
Copy link
Contributor

Still failing:

rauth/session.py:153:9: E122 continuation line missing indentation or outdented

You may want to run tests locally via tox or some other runner. Also you can check TravisCI for build failures.

@nickspring
Copy link
Author

I don't know what to do, It works for me.

@maxcountryman
Copy link
Contributor

Are you running the tests with tox?

@nickspring
Copy link
Author

I don't use tox.

@maxcountryman
Copy link
Contributor

How are you running the tests? It seems like it's not compatible with the Travis runner.

@nickspring
Copy link
Author

I'm not running any tests. I fixed only one line. It works.

@maxcountryman
Copy link
Contributor

It looks like the tests still aren't passing on Travis. More formatting errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants