Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base-16 support #46

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Base-16 support #46

merged 1 commit into from
Sep 7, 2023

Conversation

John-LittleBearLabs
Copy link
Collaborator

@John-LittleBearLabs John-LittleBearLabs commented Aug 4, 2023

Fixes #45

Also, changed how unsupported multibases are reported. No more asserting/crashing.

Simply not crashing, though, causes it to repoint to about:blank#blocked which is just a blank page so the only clue you have as to what went wrong is the confusing & misleading location bar text.

I have access to limited error reporting when canonicalizing URLs, so I decided to "successfully" canonicalize it into an identity CID ipfs:// URL (conceptually similar to a data:// URL) that points to an error message.
image

@little-bear-labs little-bear-labs deleted a comment from codecov bot Aug 4, 2023
@little-bear-labs little-bear-labs deleted a comment from codecov bot Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: +0.95% 🎉

Comparison is base (479894a) 52.45% compared to head (7e4b466) 53.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   52.45%   53.40%   +0.95%     
==========================================
  Files          48       50       +2     
  Lines        2381     2479      +98     
==========================================
+ Hits         1249     1324      +75     
- Misses       1132     1155      +23     
Files Changed Coverage Δ
library/src/libp2p/crypto/hasher.cc 57.14% <ø> (ø)
.../src/libp2p/multi/multibase_codec/codecs/base16.cc 43.03% <43.03%> (ø)
...brary/src/libp2p/multi/content_identifier_codec.cc 46.91% <46.66%> (+3.04%) ⬆️
library/src/ipfs_client/identity_cid.cc 66.66% <66.66%> (ø)
library/src/ipfs_client/block_storage.cc 57.14% <100.00%> (+0.85%) ⬆️
library/src/ipfs_client/dag_block.cc 57.34% <100.00%> (+0.91%) ⬆️
library/src/ipfs_client/gateways.cc 46.42% <100.00%> (ø)
...bp2p/multi/multibase_codec/multibase_codec_impl.cc 52.27% <100.00%> (+13.49%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

the Base-16 CIDs.
Bad base errors, too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing a base16 IPFS CID into the URL bar crashes the browser
1 participant