Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some bug fix and improvement #26

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

some bug fix and improvement #26

wants to merge 44 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2014

1.fix the build break
2.implement fiq function
3.remove 32bit code

@xiaoxiang781216
[arm64] fix minor issue in the interrupt function
3786c9e 
1.don't update F bit in arch_[dis|en]able_ints
2.get interrupt flag through daif instead of cspr

Change-Id: I1dbbe9493e1036a25095226f44607a5e3d62aaab
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arm64] implement fiq arch function
97f625e 
Change-Id: Iecbb55c13f00ea8eacf0db74112df6889a71d444
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arm64] always use gcc builtin atomic operation
87d0bf0 
and remove the inline assemble code because they can't build with a64

Change-Id: Ia2ada6ab5c670ba97fd6260b7085e068d282417e
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arm] don't use strexeq which is arm only inst in atomic_cmpxchg
25f84f6 
because atomic_cmpxchg may inline in the thumb compiler environment

Change-Id: Ifc424327211859662866022c1a9dec30618f72e6
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[kernel] move spinlock out of arch/arm/include/arch/arch_ops.h
a05d6c5 
because spinlock could implement in all supported arch

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

Change-Id: Icfb0bfbd569320cc6b3f4dc13b39f73a45ae1f92
@xiaoxiang781216
[arm_gic] remove arm 32bit specific code
144dc4d 
so the same driver could work on both 32bit and 64bit platform

Change-Id: I6955300ee40e43a3dbc853cd24328ceb94657468
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arm64] fix minor issue in the interrupt function
dbbc331 
1.don't update F bit in arch_[dis|en]able_ints
2.get interrupt flag through daif instead of cspr

Change-Id: I1dbbe9493e1036a25095226f44607a5e3d62aaab
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arm64] implement fiq arch function
251ce80 
Change-Id: Iecbb55c13f00ea8eacf0db74112df6889a71d444
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arm64] always use gcc builtin atomic operation
fb61b20 
and remove the inline assemble code because they can't build with a64

Change-Id: Ia2ada6ab5c670ba97fd6260b7085e068d282417e
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arm] don't use strexeq which is arm only inst in atomic_cmpxchg
e7d8ba9 
because atomic_cmpxchg may inline in the thumb compiler environment

Change-Id: Ifc424327211859662866022c1a9dec30618f72e6
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[kernel] move spinlock out of arch/arm/include/arch/arch_ops.h
a3c1cf3 
because spinlock could implement in all supported arch

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

Change-Id: Icfb0bfbd569320cc6b3f4dc13b39f73a45ae1f92
@xiaoxiang781216
[arm_gic] remove arm 32bit specific code
0f60ee8 
so the same driver could work on both 32bit and 64bit platform

Change-Id: I6955300ee40e43a3dbc853cd24328ceb94657468
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
Revert "[app][aboot] remove some old Google code that hasn't been use…
436c0de 
…d in a while"

Bring back the aboot support again.
This reverts commit 8c68071.

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

Conflicts:
	include/lib/ptable.h
	lib/ptable/ptable.c
	lib/ptable/rules.mk

Change-Id: I2f0ea48410d75d53f29fd4f2e0fcd7b4194572ea
@xiaoxiang781216
[lib][partition] put partition related code into one folder
3373133 
so the code organization more clearer:
1.move lib/partition to lib/partition/mbr
2.move lib/ptable to lib/partition/ptable
3.update rules.mk to pointer the new location

Change-Id: I0d173acc7bacd23c890caffbf4049e9fe91fa31c
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[lib][ptable] support access table entry by index
1a22e1d 
Change-Id: I8e5fc9c7d1ce9364d7926e901f0f42a73fa8ab01
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[app][aboot] port to the new ptable interface
7e8cec0 
Change-Id: Ia681906e2aa7f428b6eb7a5d3825b18daaf46faa
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[time] support mdelay and udelay function
5519935 
Change-Id: Iaddec5e8c87d24f2d9490ea0e483c8a439609d2d
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
provide linux-style read[w|b]()/write[w|b]() in reg.h
8703775 
Change-Id: I1ed607a9703e9e19ce78b0b27dd4ddeaf86bad59
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[vm] add vaddr_to_paddr function
46a8618 
and make paddr_to_kvaddr/vaddr_to_paddr is callable even without vm

Change-Id: I8e2e670e93ae9afc04dd8d0ef3ae4fa5982d6564
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arch] move the common code from arch_chain_load to chain_load
13e43e3 
and support chain_load for the no vm case

Change-Id: Idbdb40b39b98c7fb80ed4b4d1ac0efb0171875f8
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arch] support chain_load with arguments(max 4)
d3b4bfc 
arch specified code need pass these arguments to
the entry pointer with the suitable approach

Change-Id: I1204b87de9b81ee81526b402a20eeef2774e5774
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[vm] remove __MMU_INITIAL_MAPPING_XXXX_OFFSET and related STATIC_ASSERT
2c3fdcc 
because these definition isn't suitable for 64bit cpu and make compiler error

Change-Id: Ic896b62b5545e89b52324a49c03430aae73f9cb7
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[app][aboot] ensure aboot work well for no identity mapping
e9789e0 
by replace pointer cast with paddr_to_kvaddr/vaddr_to_paddr/chain_load3
and get the address from boot image header instead of the hardcode value

Change-Id: I5b9ce69ca2d23997948631f2b5807d24762b1cc2
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arch][arm] don't change V bit for pre armv7
d2a62c9 
because VBAR just exist on armv7 and replace KERNEL_BASE with
_start since KERNEL_BASE isn't defined when WITH_KERNEL_VM=0

Change-Id: Ic2496fe9de901564975142073121ee540972c00a
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arch][arm] make WITH_KERNEL_VM selectable
d54159d 
and turn on WITH_KERNEL_VM by default

Change-Id: I64e8f157e8fda223bc25de4735828b37e3a88151
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arch][arm] support compile cortex-a7
128c5e5 
Change-Id: I6fe3a7fa5750c0d4397f4764fbd6edf4c40cd80e
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[lib][heap] heap_grow reduce grow size when memory nearly exhaust
212f5a8 
Change-Id: I2421b536d11c043e9d07ef23638a02652ddda6da
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[lib][heap] fill the delayed free block with FREE_FILL
1a6d9d6 
and don't fill the alloced block from pmm_alloc_kpages

Change-Id: Ic879f1e1d7159cf87b37f553e30d2c654ddcc509
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[lib][heap] make the heap usable as soon as possible
a8c679f 
now the heap could be used even in the early init phase
and replace boot allocator with the heap

Change-Id: If9af3912b8685498218dc23ac899758f43f787fa
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[arch][arm] ARM_CPU support cortex-a7-neon and cortex-a8-neon
6dd1432 
so the platform could decide whether enable vfp/neon per needed

Change-Id: Ia922efaae556e95701383a1c4184a69e4891eddc
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[dev] define device_class for each class
7940351 
to standardize the class name

Change-Id: I742090d06a999b3b851f8b1a76d1599c45657f91
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[dev] device driver support the init order
4a1420c 
Change-Id: I2147b841a5d0671c74224bad70a3c80eb563cb73
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[dev] add device_find for dynamic device search
32c61d5 
which is companion with device_get_by_name(compile time)

Change-Id: I0d642caf4d5c3958cf189cb4da6b1eb1076208af
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[dev] add the generic 16550 uart driver
eff3731 
Change-Id: I5449ecccea9c344d9d9dd9c74c32495c460780a9
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[dev][timer][arm_generic] fix fixed_point.h can't find compiler error
6fb5802 
and disable local trace

Change-Id: I2b1a397481385e510b1255044686c624bec1f81e
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[dev][timer][arm_generic] add arm_generic_timer_init_freq
5b112f3 
so platform could pass in the frequency if needed

Change-Id: Icbe8de0e66eeb7e884dbda3c7df343d4d1b1357c
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[lib][sysparam] add sysparam_add_nosave function
5efcb33 
the caller can decide whether save sysparam to block device

Change-Id: I70c206d2ff2794b2163603aedf3528969c85bd57
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[app][aboot] implement cmd_getvar base on sysparam
1921230 
the platform/target could extend fastboot variable more easier

Change-Id: I927b0bc6c2efaf8d13c741955c81d7fcf9cb1859
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[vm] allocate vm_page array from self when heap exhaust
1d59d43 
do this only for already mapped arena(PMM_ARENA_FLAG_KMAP)

Change-Id: I0baa6cbe0aab0525d9b5c37674119379cb989cde
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[vm] fix address calculation beyond 4G issue
c7c2e2d 
Change-Id: Ic37b00bf63e50bfee5847b2bdda9577d00d3844d
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[dev] add device_init_range to init device in [first, last]
f79ab98 
and extend fini funtion in the same way

Change-Id: Ic0ba2fb8f4e37b64a8518d03ba62ea69b62319e2
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
[dev][16550] add reserved state in config structure
32f7b94 
and automatically call uart_init if not yet, so the
debug message could output at the very early stage.

Change-Id: Id704ac6d827b3b697cc40765786844a872a5f451
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
Merge branch 'master' of https://github.com/xiaoxiang-xiaomi/lk
450fe80
@ghost ghost changed the title arm64 arch_ops.h clean up some bug fix and improvement Oct 26, 2014
@travisg
Copy link
Member

travisg commented Oct 30, 2014

Whoa, this is a lot of code. I'm going to sort through this one at a time and see what I can do.

Looks like about 80% of it is fine right out the gate, but a few things will collide with some work I have upstream. Specifically parts dealing with the spin locks, but by and large most of it seems to be pretty okay.

github isn't particularly good at handing per commit comments, so I'll probably have to just cherry pick the changes one at a time and, submit the result and then you can rebase your changes on it and we can sort out the details. I'll post comments here for stuff that needs to be rethought.

@ghost
Copy link
Author

ghost commented Oct 30, 2014

Sure, let's disscuss the better approach if you have any new idea about the particular commit.
BTW, we just found a minor error in this commit:
[dev] add device_find for dynamic device search …
I will update the fix soon.
After this patch series get approved, we will start to send the next patch series for review.

@xiaoxiang781216
[dev] move dev to next for each loop in device_find
9be54e0 
Change-Id: I792623ca1486071a15c3373fac10cf24dde0c869
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@ghost
Copy link
Author

ghost commented Oct 30, 2014

this is the fix:
[dev] move dev to next for each loop in device_find …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travisg @xiaoxiang781216