Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filer: Callstack while entering directory twice #501

Closed
Grueslayer opened this issue Aug 14, 2020 · 9 comments · Fixed by #504
Closed

Filer: Callstack while entering directory twice #501

Grueslayer opened this issue Aug 14, 2020 · 9 comments · Fixed by #504
Labels
bug Something isn't working PR welcome vim

Comments

@Grueslayer
Copy link
Contributor

If you

  1. open filer Clap filer in any directory
  2. move with cursor to any subdir
  3. change directory with TAB
  4. go back with BS
  5. move to the same directory with cursor
  6. reenter directory with TAB

you'll see instead of the files a callstack with vim error:

provider.on_typed:
function clap#popup#move_manager#filter[3] 
..<lambda>12[1]
..clap#handler#tab_action[2]
..<SNR>140 tab action[29]
..<SNR>140 reset to[5]
..<SNR>140 filter or send message[3] 
..<SNR>140_do_filter[4]
..97, line 2
Vim(call):E315: ml_get: invalid lnum: 4

Bildschirmfoto 2020-08-14 um 20 38 39

(Selecting some of those naturally does nothing good).

This happens on MacOS and Windows using Vim.

Maybe this has something in common with #306 .

@Grueslayer Grueslayer added the bug Something isn't working label Aug 14, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@liuchengxu liuchengxu added the vim label Aug 15, 2020
@liuchengxu
Copy link
Owner

As mentioned in #306, I'm a neovim user and I'm busy these days, so if you find any solution, feel free to PR, I may not spend more time on this.

@Grueslayer
Copy link
Contributor Author

That's not good, if you stop supporting vim, i am also out of your plugin. I will be always on the stable vim side as long as Bram is keeping going on.

@liuchengxu
Copy link
Owner

Hmm, I'm not saying I won't support vim. As long as I still maintain this plugin, I'll try my best to support vim as well.

But you have to understand that since I'm a daily neovim and Linux/macOS user, this plugin works better inevitably with neovim. You can see there are some subtle vim specific issues often reported by the users instead of myself, if people report these issues, I'll absolutely look into them when I get some time. People can get some solid responses quickly when I'm not busy, but have to wait if I don't have much time for these open source projects :(.

Furthermore, there are also serveral more nice features I want to have in this plugin, if someone can help resolve the vim/windows issues, we can definitely expect a nicer vim-clap. Looks like you are capable of this, I'm more than happy to invite you as a collaborator to help me fix these kinds of problems if you do not mind, which will hopefully improve the vim support of this plugin I believe.

liuchengxu added a commit that referenced this issue Aug 20, 2020
@liuchengxu
Copy link
Owner

#504 should also fix this issue.

liuchengxu added a commit that referenced this issue Aug 20, 2020
* Let the callback also handle the error itself

- Also fix an unwrap in Rust.

Close #500

* Show the error message in the preview window

* Fix error dir

* Update CHANGELOG.md

* .

* Update CHANGELOG.md

* Close #501

* Update CHANGELOG.md

* Refine sign ensure_exists
@Grueslayer
Copy link
Contributor Author

#504 didn't fixed it for me.

@liuchengxu
Copy link
Owner

I can no longer reproduce with that patch. Have you recompiled the Rust binary locally?

@Grueslayer
Copy link
Contributor Author

Nope, using your prebuild binaries.

@liuchengxu
Copy link
Owner

That won't work as the Rust source file has been changed and you need to recompile, or you need to wait for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR welcome vim
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants