Move fzy algo from rff crate into local file and some other small tweaks to Rust code #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `find_start_at()` returns `None`, the function instantly returns `None` too. So instead of lowercasing the whole string and then splitting it into words, split it and then lowercase given words. Less lowercasing if `find_start_at()` will exit early.
Also removed vector of indices. Those could be created in place, so no need for allocation of the whole vector. Besides, `vec.extend_from_slice(slice)` desugars into something like this:
for element in slice.iter().cloned() {
vec.push(element);
}
The biggest change is fzy algo being moved from "rff" crate into one of the files in the directory. Some very little changes done to the algorithm while moving. Now Rust code could be checked and tested not on unix systems only. Also added ".lock" to gitignore for libs. The reason is explained here: https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries
liuchengxu
reviewed
Dec 26, 2019
| @@ -0,0 +1,3 @@ | |||
| /target | |||
| !.cargo | |||
| *.lock | |||
There was a problem hiding this comment.
I don't think the faq applies to our situation. Although it's a library, it's unpublished and actually used for vim-clap exclusively. No others depend on it, and we need to ensure people are always able to compile this Rust extension on their own. Keeping Cargo.lock is better for our case.
|
Overall looks good to me, except ignoring the |
|
Okay, will revert gitignoring .lock files and add my .locks to the PR, once I'm back at home. |
Removed *.lock from .gitignore for libs, added my (Windows) .locks to the pushed files.
|
Ready to merge now, I guess? |
|
Merged, thanks! |
liuchengxu
pushed a commit
that referenced
this pull request
Aug 17, 2021
* GamePower nft-collectibles-wallet Milestone 1 * updating docs for wallet pallet * updating docs for wallet example node * updating repos README to provide a better description of the project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original (MIT licensed) "rff" crate has
terminalmodule which utilizesstd::os::unixthus it doesn't compile on non-unix OS, and could not be "cargo check"ed and tested.If it is not accepted, all tweaks that don't depend on moving fzy algorithm are done in "Less allocations, more laziness" commit.