Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the long matched elements always at least partially visible #330

Merged
merged 23 commits into from
Feb 27, 2020

Conversation

liuchengxu
Copy link
Owner

@liuchengxu liuchengxu commented Feb 24, 2020

The future work is to optimize for maple grep as well.

Close #317

截屏2020-02-24下午5 14 35

@liuchengxu liuchengxu changed the title Ensure the long matched elements always visible particially Ensure the long matched elements always at least partally visible Feb 24, 2020
@liuchengxu liuchengxu changed the title Ensure the long matched elements always at least partally visible Ensure the long matched elements always at least partially visible Feb 24, 2020
@liuchengxu liuchengxu mentioned this pull request Feb 24, 2020
@YellowKirby
Copy link

This is working pretty well for me, thank you! One thing that seems a little weird is that the input line is also scrolling, even though it seems like there is room to show more of the input.

image

In this screenshot: terminal is 45 columns wide, I have not made any configuration changes to how vim-clap opens the popup. I've typed filea, but only the letter a is visible.

@liuchengxu
Copy link
Owner Author

liuchengxu commented Feb 25, 2020

I can only ensure it won't be invisible totally :(, no guarantee about occupying the whole space, feel free to improve in https://github.com/liuchengxu/vim-clap/pull/330/files#diff-bc69e7d07f276d599a29af5c04661940R111 .

About filea issue, feel free to create a new issue if you can reproduce, I never see it.

@liuchengxu liuchengxu merged commit 7338b67 into master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long matched results can cause the matched portion to not be visible
2 participants