-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle multi dimentional arrays in path decoder #83
base: master
Are you sure you want to change the base?
Conversation
Thanks @dmitrytrager . What's your use case? Multi-dimentional arrays will not work nicely with this library due to its limitations. |
My case is exactly like mentioned: nested arrays within hash. |
I see. But generally, the diff generated by multi-dimensional arrays will be very bad to be useful. |
Could you please give more details about reasons here? |
The reason is that telling whether two arrays are similar may not make much sense in most scenarios. |
Sorry, I don't get how does less frequent scenario mean "very bad to be useful" |
I don't have objective data to tell whether it's generally useful or not. I just want to avoid disappointing the users with a feature that is not well-considered. Anyway, thank you for making the PR and making the use case known. Let's wait for more users to share their feedback on this feature. |
Ok, having feedback would be great |
This fixes issue related to handling multi dimensional arrays in path