Merge pull request #111 from keradus/CS

CS: Better PSR2 following

adapters/Behat/ListFeaturesExtension/Console/Processor/ListFeaturesProcessor.php

@@ -44,10 +44,16 @@ public function __construct(SpecificationLocator $locator, SuiteRepository $regi
     */
     public function configure(Command $command)
     {
-        $command->addOption('list-features', null, InputOption::VALUE_NONE,
+        $command->addOption(
+            'list-features',
+            null,
+            InputOption::VALUE_NONE,
             'Output a list of feature files to be executed by Behat'
         );
-        $command->addOption('list-scenarios', null, InputOption::VALUE_NONE,
+        $command->addOption(
+            'list-scenarios',
+            null,
+            InputOption::VALUE_NONE,
             'Output a list of individual scenarios to be executed by Behat'
         );
     }

adapters/Behat/features/bootstrap/FeatureContext.php

@@ -25,8 +25,10 @@ public function iRunBehat($argumentsString = '')
             $argumentsString .= ' 2>&1';
         }
 
-        exec($command = sprintf('%s %s',
-            BEHAT_BIN_PATH, $argumentsString
+        exec($command = sprintf(
+            '%s %s',
+            BEHAT_BIN_PATH,
+            $argumentsString
         ), $output, $return);
 
         $this->lastBehatStdOut  = trim(implode("\n", $output));

adapters/Behat2/ListFeaturesExtension/Console/Processor/ListFeaturesProcessor.php

@@ -35,10 +35,16 @@ public function __construct(ContainerInterface $container)
      */
     public function configure(Command $command)
     {
-        $command->addOption('list-features', null, InputOption::VALUE_NONE,
+        $command->addOption(
+            'list-features',
+            null,
+            InputOption::VALUE_NONE,
             'Output a list of feature files to be executed by Behat'
         );
-        $command->addOption('list-scenarios', null, InputOption::VALUE_NONE,
+        $command->addOption(
+            'list-scenarios',
+            null,
+            InputOption::VALUE_NONE,
             'Output a list of individual scenarios to be executed by Behat'
         );
     }

adapters/Behat2/features/bootstrap/FeatureContext.php

@@ -35,8 +35,11 @@ public function iRunBehat($argumentsString = '')
             $argumentsString .= ' 2>&1';
         }
 
-        exec($command = sprintf('%s %s %s --no-time',
-            BEHAT_PHP_BIN_PATH, escapeshellarg(BEHAT_BIN_PATH), $argumentsString
+        exec($command = sprintf(
+            '%s %s %s --no-time',
+            BEHAT_PHP_BIN_PATH,
+            escapeshellarg(BEHAT_BIN_PATH),
+            $argumentsString
         ), $output, $return);
 
         $this->lastBehatStdOut  = trim(implode("\n", $output));

src/Command/ParallelCommand.php

@@ -122,17 +122,18 @@ private function getMaxNumberOfProcess($maxNumberOfParallelProc)
      * @param ProcessesManager $processManager
      * @return array
      */
-    private function doExecute(InputInterface $input,
-                               OutputInterface $output,
-                               QueueInterface $queue,
-                               ProcessesManager $processManager)
-    {
+    private function doExecute(
+        InputInterface $input,
+        OutputInterface $output,
+        QueueInterface $queue,
+        ProcessesManager $processManager
+    ) {
         $processes = null;
 
         if ($this->isVerbose($output)) {
             $progressBar = new VerboseRenderer($queue->count(), $this->hasErrorSummary($input), $output);
         } else {
-            $progressBar = new ProgressBarRenderer($queue->count(),$this->hasErrorSummary($input), $output, new ProgressBar($output));
+            $progressBar = new ProgressBarRenderer($queue->count(), $this->hasErrorSummary($input), $output, new ProgressBar($output));
         }
 
         $progressBar->renderHeader($queue);
@@ -145,7 +146,7 @@ private function doExecute(InputInterface $input,
          * @var Processes $processes
          */
         $processes->cleanUP(); //it is not getting called with -p1 after the last process otherwise
-        $processes->wait(function() use ($progressBar, $queue, $processes) {
+        $processes->wait(function () use ($progressBar, $queue, $processes) {
             $progressBar->renderBody($queue, $processes);
         });
         $progressBar->renderFooter($queue, $processes);

src/Process/ProcessesManager.php

@@ -69,7 +69,7 @@ private function createProcessesForTheBeforeCommand($range, Processes &$processe
             $process = $this->processFactory->createAProcessForACustomCommand($this->beforeCommand, $currentChannel, $currentProcessNumber, $this->isFirstForThisChannel($currentChannel));
             $processes->add($currentChannel, $process);
             $processes->start($currentChannel);
-            $processes->wait(function() use ($processes){
+            $processes->wait(function () use ($processes) {
                 if ($processes->getExitCode()) {
                     $errorOutput = $processes->getErrorOutput();
                     $output = current($errorOutput);

src/Process/Report.php

@@ -18,13 +18,14 @@ class Report
      * @param string|null $errorBuffer
      * @param boolean $isFirstOnThread
      */
-    public function __construct($suite, 
-                                $isSuccess,
-                                $time,
-                                $processorNumber,
-                                $errorBuffer,
-                                $isFirstOnThread)
-    {
+    public function __construct(
+        $suite,
+        $isSuccess,
+        $time,
+        $processorNumber,
+        $errorBuffer,
+        $isFirstOnThread
+    ) {
         $this->isSuccess = $isSuccess;
         $this->processorNumber = $processorNumber;
         $this->suite = $suite;

src/Queue/CreateTestsQueueFromPhpUnitXML.php

@@ -29,11 +29,11 @@ public static function execute($xmlFile)
 
     private static function processTestSuite(TestsQueue $testSuites, \PHPUnit\Framework\TestSuiteIterator $testSuiteIterator)
     {
-        foreach ($testSuiteIterator as $testSuite)  {
+        foreach ($testSuiteIterator as $testSuite) {
             self::addTestFile($testSuites, $testSuite);
 
             if ($testSuite instanceof \PHPUnit\Framework\TestSuite) {
-                    self::processTestSuite($testSuites, $testSuite->getIterator());
+                self::processTestSuite($testSuites, $testSuite->getIterator());
             }
         }
     }
@@ -46,4 +46,4 @@ private static function addTestFile(TestsQueue $testSuites, $testSuite)
             $testSuites->add($class->getFileName());
         }
     }
-}
+}

tests/Environment/FastestEnvironmentTest.php

@@ -2,15 +2,13 @@
 
 namespace Liuggio\Fastest\Environment;
 
-
 use Liuggio\Fastest\Process\EnvCommandCreator;
 
 /**
  *
  */
 class FastestEnvironmentTest extends \PHPUnit\Framework\TestCase
 {
-
     public function setup()
     {
         $envName = EnvCommandCreator::ENV_TEST_CHANNEL_READABLE;

tests/Process/ProcessFactoryTest.php

@@ -2,7 +2,6 @@
 
 namespace Liuggio\Fastest\Process;
 
-
 class ProcessFactoryTest extends \PHPUnit\Framework\TestCase
 {
 
@@ -75,4 +74,3 @@ public function shouldReplaceThePlaceholder()
         );
     }
 }
-

tests/Process/ProcessesManagerTest.php

@@ -2,7 +2,6 @@
 
 namespace Liuggio\Fastest\Process;
 
-
 use Liuggio\Fastest\Queue\TestSuite;
 use Symfony\Component\Process\Process;
 
@@ -57,7 +56,7 @@ public function shouldCreateProcessesWithoutBeforeProcessExecutingFactoryWithThe
         $factory->expects($this->exactly(1))
             ->method('createAProcess')
             ->with($this->anything(), $this->equalTo(1), $this->equalTo(1), $this->equalTo(true))
-            ->willReturn(new Process('echo ',rand()));
+            ->willReturn(new Process('echo ', rand()));
 
 
         $manager = new ProcessesManager($factory, 1);
@@ -84,7 +83,7 @@ public function shouldCreate6ProcessesGivingThemTheCorrectEnvParameters()
             ->getMock();
         $processes->expects($this->any())
             ->method('getIndexesOfCompletedChannel')
-            ->willReturn(range(1,3));
+            ->willReturn(range(1, 3));
         $processes->expects($this->any())
             ->method('add')
             ->willReturn(true);
@@ -109,7 +108,7 @@ public function shouldCreate6ProcessesGivingThemTheCorrectEnvParameters()
             $factory->expects($this->at($at))
                 ->method('createAProcess')
                 ->with($this->anything(), $this->equalTo($expectation[0]), $this->equalTo($expectation[1]), $this->equalTo($expectation[2]))
-                ->willReturn(new Process('echo ',rand()));
+                ->willReturn(new Process('echo ', rand()));
         }
 
         $manager = new ProcessesManager($factory, 1);

tests/Queue/CreateTestsQueueFromSTDINTest.php

@@ -64,7 +64,7 @@ private function executeCommandWithDelayedStdin($command, $stdinLines, $delayMic
         // 1 => readable handle connected to child stdout
         // 2 => readable handle connected to child stderr
 
-        foreach($stdinLines as $stdinLine) {
+        foreach ($stdinLines as $stdinLine) {
             usleep($delayMicroseconds);
             fwrite($pipes[0], $stdinLine);
         }

tests/Queue/Infrastructure/InMemoryQueueFactoryTest.php

@@ -15,4 +15,4 @@ public function shouldCreateAQueue()
 
         $this->assertInstanceOf('\Liuggio\Fastest\Queue\Infrastructure\InMemoryQueue', $queue);
     }
-} 
+}

tests/Queue/Infrastructure/InMemoryQueueTest.php

@@ -19,4 +19,4 @@ public function shouldPopAndPushASuite()
         $this->assertEquals('a', $queue->pop());
         $this->assertTrue($queue->isEmpty());
     }
-} 
+}

tests/Queue/ReadFromInputAndPushIntoTheQueueTest.php

@@ -2,8 +2,8 @@
 
 namespace Liuggio\Fastest\Queue;
 
-
-class ReadFromInputAndPushIntoTheQueueTest extends \PHPUnit\Framework\TestCase {
+class ReadFromInputAndPushIntoTheQueueTest extends \PHPUnit\Framework\TestCase
+{
 
     /**
      * @test