Raised PHPStan to level 5

liuggio · Oct 7, 2020 · f844c76 · f844c76
1 parent d3d8514
commit f844c76
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 10 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -2,7 +2,10 @@ includes:
     - vendor/phpstan/phpstan-phpunit/extension.neon 
 
 parameters:
-	level: 3
+	level: 5
 	paths:
 		- src
-		- tests
+		- tests
+	reportUnmatchedIgnoredErrors: false
+	ignoreErrors: #see https://github.com/phpstan/phpstan/issues/1267#issuecomment-552874947 -> @todo remove when sf 3.4 support ends
+	    - "#^Call to an undefined static method #"
diff --git a/src/Process/ProcessorCounter.php b/src/Process/ProcessorCounter.php
@@ -55,6 +55,7 @@ private function readFromProcCPUInfo()
                 $process = Process::fromShellCommandline($executeCommand);
             } else {
                 // Drop when sf 3.4 supports ends
+                /** @phpstan-ignore-next-line */ // @todo remove when sf 3.4 support ends
                 $process = new Process($executeCommand);
             }
             $process->run();

diff --git a/src/Process/Report.php b/src/Process/Report.php
@@ -14,7 +14,7 @@ class Report
     /**
      * @param string      $suite
      * @param bool        $isSuccess
-     * @param int         $time
+     * @param float       $time
      * @param int         $processorNumber
      * @param string|null $errorBuffer
      * @param bool        $isFirstOnThread
@@ -68,7 +68,7 @@ public function getSuite()
     }
 
     /**
-     * @return int Time in microseconds
+     * @return float Time in microseconds
      */
     public function getTime()
     {

diff --git a/src/Queue/CreateTestsQueueFromPhpUnitXML.php b/src/Queue/CreateTestsQueueFromPhpUnitXML.php
@@ -41,7 +41,7 @@ public static function execute($xmlFile)
 
     private static function processTestSuite(
         TestsQueue $testSuites,
-        \PHPUnit\Framework\TestSuiteIterator $testSuiteIterator
+        \Iterator $testSuiteIterator
     ) {
         foreach ($testSuiteIterator as $testSuite) {
             self::addTestFile($testSuites, $testSuite);

diff --git a/src/UI/VerboseRenderer.php b/src/UI/VerboseRenderer.php
@@ -52,7 +52,7 @@ public function renderBody(QueueInterface $queue, Processes $processes)
 
         $log = $processes->getReport();
         $count = count($log);
-        $tests = array_slice($log, $this->lastIndex, $count, 1);
+        $tests = array_slice($log, $this->lastIndex, $count, true);
 
         foreach ($tests as $report) {
             ++$this->lastIndex;
@@ -90,7 +90,7 @@ public function renderBody(QueueInterface $queue, Processes $processes)
     /**
      * Method to format duration to human readable format.
      *
-     * @param int $milliseconds
+     * @param float $milliseconds
      *
      * @return string
      */

diff --git a/tests/Process/ProcessesManagerTest.php b/tests/Process/ProcessesManagerTest.php
@@ -30,7 +30,7 @@ public function shouldCreateBeforeProcessesExecutingFactoryWithTheCorrectArgumen
         $this->assertTrue($manager->assertNProcessRunning($queue, $processes));
     }
 
-    /**
+    /**src/UI/VerboseRenderer.php
      * @test
      */
     public function shouldCreateProcessesWithoutBeforeProcessExecutingFactoryWithTheCorrectArguments()
@@ -57,7 +57,7 @@ public function shouldCreateProcessesWithoutBeforeProcessExecutingFactoryWithThe
         $factory->expects($this->exactly(1))
             ->method('createAProcess')
             ->with($this->anything(), $this->equalTo(1), $this->equalTo(1), $this->equalTo(true))
-            ->willReturn(new Process(['echo '], rand()));
+            ->willReturn(new Process(['echo '], (string) rand()));
 
         $manager = new ProcessesManager($factory, 1);
 
@@ -107,7 +107,7 @@ public function shouldCreate6ProcessesGivingThemTheCorrectEnvParameters()
             $factory->expects($this->at($at))
                 ->method('createAProcess')
                 ->with($this->anything(), $this->equalTo($expectation[0]), $this->equalTo($expectation[1]), $this->equalTo($expectation[2]))
-                ->willReturn(new Process(['echo '], rand()));
+                ->willReturn(new Process(['echo '], (string) rand()));
         }
 
         $manager = new ProcessesManager($factory, 1);