Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior variations of different versions of symfony process in tests #122

Merged
merged 3 commits into from
Dec 13, 2017
Merged

Fix behavior variations of different versions of symfony process in tests #122

merged 3 commits into from
Dec 13, 2017

Conversation

francoispluchino
Copy link
Collaborator

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #116
License MIT
Doc PR ~

To follow the discussion of the issue #116, I confirm that the problem stems from a different behavior between versions of the Symfony Process component. In the < 3.2 versions, each value of the environment variables is converted to binary, whereas in the >= 3.2 versions, the values are directly added without conversion. You can see the difference in the code:

So in our tests, you just have to convert each value into binaries for the 2 compared arrays. In this way we remove cast variations from the values of the Symfony Process component.

@DonCallisto
Copy link
Collaborator

LGTM. I'm gonna close #116 in favor of this. Thank you!

@DonCallisto DonCallisto merged commit c63d56d into liuggio:master Dec 13, 2017
@DonCallisto
Copy link
Collaborator

DonCallisto commented Dec 13, 2017

Thank you again!

@DonCallisto
Copy link
Collaborator

We are ready for 1.6: as all the work was done by you, would you mind to write here release notes so I can include all new features in the release page?

Thank you man, without your help we would be stuck for weeks!

Cheers 🍺

PS.: I see that you don't have collaborator role: would you like to join the team? At first glance you seem to know fastest better than me 😄

@francoispluchino
Copy link
Collaborator Author

Why not ! You can add me as collaborator.

Regarding the release page, do you want me to write the release note in the dedicated section on Github?

@DonCallisto
Copy link
Collaborator

Regarding the release page, do you want me to write the release note in the dedicated section on Github?

Yes please!

@francoispluchino
Copy link
Collaborator Author

I do not have access permissions to create a release note.

@DonCallisto
Copy link
Collaborator

I wrote to @liuggio because I cannot add you as collaborator.
BTW you can write here and I'll report them in next release.

I've also seen that there's a little problem with #99 so I'll wait for release until notes and #99 patch.

Thanks.

@francoispluchino francoispluchino deleted the fix-symfony-process branch December 14, 2017 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants