Fix behavior variations of different versions of symfony process in tests #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow the discussion of the issue #116, I confirm that the problem stems from a different behavior between versions of the Symfony Process component. In the
< 3.2
versions, each value of the environment variables is converted to binary, whereas in the>= 3.2
versions, the values are directly added without conversion. You can see the difference in the code:So in our tests, you just have to convert each value into binaries for the 2 compared arrays. In this way we remove cast variations from the values of the Symfony Process component.