Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement table widget for Ecto queries #34

Merged
merged 5 commits into from
Jul 23, 2021
Merged

Implement table widget for Ecto queries #34

merged 5 commits into from
Jul 23, 2021

Conversation

jonatanklosko
Copy link
Member

Mostly useful with Kino as a dev dependency in Mix projects, but may also be useful for Ecto tutorial notebooks.

kino_ecto.mp4

@jonatanklosko
Copy link
Member Author

Here is a self-contained example notebook.

josevalim
josevalim reviewed Jul 22, 2021
View reviewed changes
lib/kino/ecto.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Jul 22, 2021
View reviewed changes
lib/kino/utils/table.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Jul 22, 2021
View reviewed changes
lib/kino/utils/table.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments added. We should probably devise a testing scheme where we emulate the messages to handle some of the corner cases.

josevalim
josevalim reviewed Jul 23, 2021
View reviewed changes
lib/kino/utils/table.ex Outdated Show resolved Hide resolved
jonatanklosko and others added 2 commits July 23, 2021 10:49
@jonatanklosko @josevalim
Update lib/kino/utils/table.ex
aafb63c 
Co-authored-by: José Valim <jose.valim@dashbit.co>
@jonatanklosko
Add tests for the Ecto widget
72b62c4
@jonatanklosko jonatanklosko merged commit a3092e6 into main Jul 23, 2021
@jonatanklosko jonatanklosko deleted the jk-ecto branch July 23, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonatanklosko @josevalim