-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook does not respond to key-presses after waking from sleep #1015
Comments
Thank you @simonmcconnell! Can you please check if this issue happens in other browsers? Also, for how long does Livebook sleep? Is it a matter of a few seconds or close to a minute or more? |
Initially I had the laptop closed overnight, but if I sleep and wake it up straight away it does it. Firefox seems fine. Chrome has same issue. Do you want me to try Opera, Brave, Vivaldi...? |
@simonmcconnell Firefox and Chrome is enough, thank you! |
The problem is that we don't handle reconnection properly, this can be reproduced with Apparently, Firefox keeps the connection on Windows hibernation, while Chrome/Edge don't, thanks @wojtekmach for helping to debug this! |
Environment
livebook server
git rev-parse HEAD
if running with mix):0.5.2
Current behavior
Start app with
iex.bat --sname myname --cookie mycookie -S mix phx.server
Start livebook with
livebook server
Connect to node (same thing happens with Elixir Standalone though)
Create a notebook, type some stuff, save it.
Put computer to sleep.
Wake computer.
(I think you have to reconnect to the node at this point)
Type in notebook -> typing does nothing, autosave still triggers. Above error seen in browser console. Can create new sections, but can't type in them.
If I close and then open the notebook, I see all the random stuff I was typing in the notebook.
Expected behavior
Things I type would appear in the notebook.
The text was updated successfully, but these errors were encountered: