Reinitialize hooks on reconnection #1018
Conversation
jonatanklosko
force-pushed
the
jk-reconnect
branch
from
76a56b0
to
616211e
Compare
| end) | ||
| } | ||
|
|
||
| push_event(socket, "session_init", payload) |
There was a problem hiding this comment.
Sorry for a silly question, where is this event handled? I noticed we removed def handle_event("session_init" elsewhere in the PR.
There was a problem hiding this comment.
It's the flow that changed :D
Previously we would load the page, mount the JS hook and from there we would pushEvent("session_init", ...) to the server, so we needed handle_event, and the server would reply. We effectively did an additional roundtrip for the initial data.
Now we do the push_event directly from the server as part of the initialization, so it's transferred together with the render payload. Then we do handleEvent("session_init", ...) on the client to receive this data. This works, because LV first mounts the JS hooks and only then dispatches the events :)
Closes #1015.