Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable word wrapping on editors #848

Closed
epfahl opened this issue Jan 10, 2022 · 6 comments
Closed

Configurable word wrapping on editors #848

epfahl opened this issue Jan 10, 2022 · 6 comments
Labels
area:frontend Related to UI/UX feature New feature or request

Comments

@epfahl
Copy link

epfahl commented Jan 10, 2022

What are thoughts on updating the markdown experience in Livebook? I always find it quite jarring that a new editor window opens after double-clicking a markdown cell. While I do like the live preview in Livebook, I've grown accustomed to the markdown flow in Juptyer, which is more like in-line editing. Perhaps the best of both worlds is possible, where formatted results are shown while editing (as in the Bear note taking app), and then markdown characters are stripped out when the editing cell is "executed."

Another feature I'd love to see re-investigated (I think this has been discussed elsewhere) is line wrapping in markdown edit cells. It's challenging to edit longer content when the editor cell shows only a single line.

Thanks for your consideration!

@josevalim
Copy link
Contributor

Hi @epfahl!

For now we wil keep the editor experience as is, although I understand it is not to everyone's taste. However, I think we should investigate how line wrapping works.

@jonatanklosko would it be possible to make the "Line wrap" show up when doing a right-click on the editor? Or do you have other ideas here?

@jonatanklosko
Copy link
Member

jonatanklosko commented Jan 10, 2022

would it be possible to make the "Line wrap" show up when doing a right-click on the editor? Or do you have other ideas here?

I think we should be consistent and either always wrap or not, otherwise the experience is confusing. Also note that the font and spacing differs, so when double clicking the word, once the editor opens the cursor would point to a different word either way.

To me it's more of a question what kind of content do we prefer (when opening a notebook in other editor or viewing on GitHub). To me nudging the user to include line breaks is good because the resulting text may be easier to read (similarly to how we don't write docstrings in a single line), but opinions may certainly differ here ^^

@epfahl
Copy link
Author

epfahl commented Jan 10, 2022

@jonatanklosko would it be possible to make the "Line wrap" show up when doing a right-click on the editor? Or do you have other ideas here?

Even just line wrapping would be a significant ergonomic improvement (for me, at least). I've been experimenting with "literate coding" in Livebook, where prose is front and center, and it wouldn't be stylistically appropriate to introduce non-paragraph line breaks.

@josevalim
Copy link
Contributor

I think there are two paths here: a default configuration and editor settings. I think editor settings would be a good starting point. My question is if we can configure the contextual/right-click menu here:

image

Worth investigating?

@epfahl
Copy link
Author

epfahl commented Jan 10, 2022

I think there are two paths here: a default configuration and editor settings. I think editor settings would be a good starting point. My question is if we can configure the contextual/right-click menu here:

I'm looking forward to seeing how this unfolds. Also, TIL there's a contextual right-click menu! 👍

@josevalim josevalim changed the title Update markdown experience? Configurable word wrapping on editors Jan 13, 2022
@josevalim josevalim added area:frontend Related to UI/UX feature New feature or request labels Jan 13, 2022
@jonatanklosko
Copy link
Member

Closed via #961.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend Related to UI/UX feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants