Controls how lines should wrap of the editor

[oo6]

solve #848

Some variable names from vscode

[josevalim]

Thank you @oo6! Before adding a global editor configuration, do you think this could be added directly to the editor instead? I think configuring it on a case-by-case basis would be more useful. :)

[oo6]

Thanks for the review, I tried it.

Monaco editor can't add submenus in the context menu(monaco-editor#1947), so I'm only add Toggle word wrapping.

@josevalim @jonatanklosko what do you think? And should I remove the global config?

[josevalim]

I like this a lot @oo6! Once you click, does it show in the select menu that it is “toggled”? If it doesn’t, maybe we should have “Enable word wrapping” and “Disable word wrapping” instead? Can we add keyboard shortcuts to it?

[oo6]

Once you click, does it show in the select menu that it is “toggled”? If it doesn’t, maybe we should have “Enable word wrapping” and “Disable word wrapping” instead?

Use the latter, and display it according to the different conditions.

Can we add keyboard shortcuts to it?

Yes, which shortcuts do you recommend? I followed vscode always uses alt-z to Toggle word wrapping.

[josevalim]

Yes, which shortcuts do you recommend? I followed vscode always uses alt-z to Toggle word wrapping.

Yes, we should use the same shortcut. Can we list it as part of the menu item too? :)

[josevalim]

Yes, we should use the same shortcut. Can we list it as part of the menu item too? :)

Nevermind, I saw you already did it. :D Great job! Let's remove the global configuration and this is good to go!

[oo6]

Let's remove the global configuration and this is good to go!

Done.

[jonatanklosko]

Beautiful, just one comment and we can ship it!

[jonatanklosko]

Thank you!!