-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controls how lines should wrap of the editor #961
Conversation
Thank you @oo6! Before adding a global editor configuration, do you think this could be added directly to the editor instead? I think configuring it on a case-by-case basis would be more useful. :) |
Thanks for the review, I tried it.
@josevalim @jonatanklosko what do you think? And should I remove the global config? |
I like this a lot @oo6! Once you click, does it show in the select menu that it is “toggled”? If it doesn’t, maybe we should have “Enable word wrapping” and “Disable word wrapping” instead? Can we add keyboard shortcuts to it? |
Use the latter, and display it according to the different conditions.
Yes, which shortcuts do you recommend? I followed |
Yes, we should use the same shortcut. Can we list it as part of the menu item too? :) |
Nevermind, I saw you already did it. :D Great job! Let's remove the global configuration and this is good to go! |
Done. |
Beautiful, just one comment and we can ship it! |
Thank you!! |
solve #848
Some variable names from
vscode