Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect after authentication #1112

Merged
merged 6 commits into from
Apr 15, 2022
Merged

Redirect after authentication #1112

merged 6 commits into from
Apr 15, 2022

Conversation

ByeongUkChoi
Copy link
Contributor

via #1103

put session referer before authentication
and get referer and delete session after authentic ation.
finally redirect to referer

@ByeongUkChoi ByeongUkChoi marked this pull request as draft April 14, 2022 15:21
@ByeongUkChoi ByeongUkChoi marked this pull request as ready for review April 14, 2022 15:28
@jonatanklosko
Copy link
Member

Hey @ByeongUkChoi, awesome! Could you add a test for this as well? :)

Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! :shipit:

@jonatanklosko jonatanklosko merged commit 120eb2d into livebook-dev:main Apr 15, 2022
@ByeongUkChoi
Copy link
Contributor Author

Thank you 😄

@ByeongUkChoi ByeongUkChoi deleted the feature/redirect_after_auth branch April 15, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants