Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VegaLite widget integration #306

Merged
merged 5 commits into from
May 31, 2021
Merged

Add VegaLite widget integration #306

merged 5 commits into from
May 31, 2021

Conversation

jonatanklosko
Copy link
Member

@jonatanklosko jonatanklosko commented May 28, 2021

Further work towards #189.

See Kino.VegaLite and the demo notebook.

kino.mp4

@@ -0,0 +1,32 @@
defmodule LivebookWeb.SessionLive.LiveWidget.VegaLiteLive do
use LivebookWeb, :live_view
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this as a LV instead of component after all, so that the widget server can detect once it goes down by monitoring it.

@josevalim
Copy link
Contributor

Exciting! I have dropped some comments. If you want to discuss any of these things in particular, please let me know.

I have only one remaining nitpick. Should we call it LiveWidget or Livewidget? I think it is already a bit confusing that we have Livebook and LiveView with different casings but I think it is understandable, they are effectively separate "products". But I think adding LiveWidget will make things more confusing...

Alternatively we give it another name altogether... maybe something that stays closer with the livebook/notebook nameset?

@josevalim
Copy link
Contributor

We can also just call it something else altogether. Here is a suggestion: Kino - Interactive widgets for Livebook. It is short and has good etymology:

kino-

before vowels, kin-, word-forming element in use from late 19c. and meaning "motion," from Greek kino-, from kinein "to move" (from PIE root *keie- "to set in motion").

Also flip books were known as kinographs, which is the closest we get to an animation in a book. :)

@Benjamin-Philip
Copy link
Contributor

Benjamin-Philip commented May 31, 2021

Just FYI, the word "kino" refers to a sort of gum used for tanning. See https://g.co/kgs/K6dHiQ. That might be worth taking into consideration.

However when most people think of kino, it relates to films and cinema. Which is what we are trying to go for.

+1 for kino.

@jonatanklosko
Copy link
Member Author

@josevalim I wanted to discuss the LiveWidget name anyway, Kino sounds absolutely great to me!

@jonatanklosko jonatanklosko changed the title Add support for LiveWidget.VegaLite Add VegaLite widget integration May 31, 2021
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped one comment and this looks good to go!

@jonatanklosko jonatanklosko marked this pull request as ready for review May 31, 2021 20:47
@jonatanklosko jonatanklosko merged commit ce7adef into main May 31, 2021
@jonatanklosko jonatanklosko deleted the jk-vl-widget branch May 31, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants