-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VegaLite widget integration #306
Conversation
@@ -0,0 +1,32 @@ | |||
defmodule LivebookWeb.SessionLive.LiveWidget.VegaLiteLive do | |||
use LivebookWeb, :live_view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this as a LV instead of component after all, so that the widget server can detect once it goes down by monitoring it.
lib/livebook_web/live/session_live/live_widget/vega_lite_live.ex
Outdated
Show resolved
Hide resolved
lib/livebook_web/live/session_live/live_widget/vega_lite_live.ex
Outdated
Show resolved
Hide resolved
Exciting! I have dropped some comments. If you want to discuss any of these things in particular, please let me know. I have only one remaining nitpick. Should we call it LiveWidget or Livewidget? I think it is already a bit confusing that we have Livebook and LiveView with different casings but I think it is understandable, they are effectively separate "products". But I think adding LiveWidget will make things more confusing... Alternatively we give it another name altogether... maybe something that stays closer with the livebook/notebook nameset? |
We can also just call it something else altogether. Here is a suggestion: Kino - Interactive widgets for Livebook. It is short and has good etymology:
Also flip books were known as kinographs, which is the closest we get to an animation in a book. :) |
Just FYI, the word "kino" refers to a sort of gum used for tanning. See https://g.co/kgs/K6dHiQ. That might be worth taking into consideration. However when most people think of kino, it relates to films and cinema. Which is what we are trying to go for. +1 for kino. |
@josevalim I wanted to discuss the |
b7b7c7c
to
727f0cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dropped one comment and this looks good to go!
Further work towards #189.
See Kino.VegaLite and the demo notebook.
kino.mp4