Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the evaluation time next to the cell indicator #366

Merged
merged 13 commits into from
Jun 20, 2021
Merged

Show the evaluation time next to the cell indicator #366

merged 13 commits into from
Jun 20, 2021

Commits on Jun 18, 2021

  1. Display the time in seconds 

    Show the evaluation time next to the cell indicator
    @shavit
    shavit committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    5cdc4b6 View commit details
    Browse the repository at this point in the history

  2. Test session data

    @shavit
    shavit committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    8c06b0c View commit details
    Browse the repository at this point in the history

  3. Send evaluation time to session 

    Start the evaluation time inside the evaluator, display the time in seconds
or milliseconds.

The output is not a string but a map
    @shavit
    shavit committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    106f8cc View commit details
    Browse the repository at this point in the history

  4. Add metadata to evaluation_response

    @shavit
    shavit committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    cdda4f1 View commit details
    Browse the repository at this point in the history

  5. Wrap the evaluation indicator in a tooltip 

      • Add metadata argument to the evaluation_response message
  • Use a tooltip to display the evaluation time
    @shavit
    shavit committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    af9880e View commit details
    Browse the repository at this point in the history

  6. Display the toolip below the indicator

    @shavit
    shavit committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    45a04f0 View commit details
    Browse the repository at this point in the history

  7. Remove the evaluation start time

    @shavit
    shavit committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    69b56b2 View commit details
    Browse the repository at this point in the history

  8. Make the tooltip optional

    @shavit
    shavit committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    c0aa243 View commit details
    Browse the repository at this point in the history

  9. Rename finish_cell_evaluation

    @shavit
    shavit committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    6a4f24c View commit details
    Browse the repository at this point in the history

  10. Evaluator tests

    @shavit
    shavit committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    1487d0d View commit details
    Browse the repository at this point in the history

  11. Update test to accespt metadata

    @shavit
    shavit committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    8f0ccbe View commit details
    Browse the repository at this point in the history

  12. Pass the evaluated time as a third argument

    @shavit
    shavit committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    4b299df View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2021

  1. Make status tooltip more generic

    @jonatanklosko
    jonatanklosko committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    52dfcb8 View commit details
    Browse the repository at this point in the history