Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve intellisense to handle structs and sigils #513

Merged
merged 6 commits into from
Aug 23, 2021

Conversation

jonatanklosko
Copy link
Member

Improvements thanks to @josevalim's work on elixir-lang/elixir#11197.

completion_up.mp4

Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, This looks good to me!

there is just one thing to consider. In IEx we show private modules because it is likely you are using it to access private API in a lib. But this is very unlikely here. Should we simply hide modules with doc false? At least for structs but I would consider it in general.

@jonatanklosko
Copy link
Member Author

@josevalim completing private modules may still be useful. For example, someone may use the Mix runtime instead of iex -S mix and then it's nice if we still complete their private modules. Perhaps we should change the text for entities with doc false to be something like "This is a private API"?

@josevalim
Copy link
Contributor

I think that can be good for surround but for cursor context, I would rather optimize it for the majority of use cases. :) imagine using Ecto for the first time and getting all of the private modules listed :D

@jonatanklosko
Copy link
Member Author

Right, makes sense! :D

@jonatanklosko jonatanklosko merged commit acd100f into main Aug 23, 2021
@jonatanklosko jonatanklosko deleted the jk-intellisense branch August 23, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants