Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime info panel #692

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Add runtime info panel #692

merged 3 commits into from
Nov 9, 2021

Conversation

jonatanklosko
Copy link
Member

@jonatanklosko jonatanklosko commented Nov 9, 2021

Didn't focus on the side panel design, since we're gonna have it redesigned anyway :)

runtimes.mp4

@josevalim
Copy link
Contributor

@jonatanklosko when there is no runtime, maybe we can show something like "Type: Elixir standalone" with both "Connect" and "Settings" button? This way we can remove the default note from the modal, because the default will be clear on the sidebar. WDYT?

@josevalim
Copy link
Contributor

I also think we can remove the "The code is evaluated in a separate Elixir runtime (node), which you can configure yourself here. " leading paragraph from the modal.

@jonatanklosko
Copy link
Member Author

jonatanklosko commented Nov 9, 2021

when there is no runtime, maybe we can show something like "Type: Elixir standalone" with both "Connect" and "Settings" button?

Do we need to optimise that though? I think it will be confusing to show runtime information even though it's not really connected. If the user wants to go with the default runtime, they won't connect manually anyway and just start evaluating stuff. If they are opening the runtime panel before evaluation, it's likely they actually want to pick another runtime type.

I also think we can remove the "The code is evaluated in a separate Elixir runtime (node), which you can configure yourself here. " leading paragraph from the modal.

Sounds good, and if we want to keep the information we could also use a question mark with a tooltip (that said, it's fine not to ^^).

@josevalim
Copy link
Contributor

Do we need to optimise that though?

I mostly want to avoid the case where someone wants to double check the runtime being used and now they need to click to open the modal. To avoid confusion, I am sure Aakash can make something that makes it clear if it is connected or not. In any case, we don't need to have the "Connect" button but I do think we should show the default runtime.

@jonatanklosko
Copy link
Member Author

jonatanklosko commented Nov 9, 2021

Let me know if that's enough for Aakash to iterate on :)

runtime_panel.mp4

Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonatanklosko beautiful! Please merge and deploy so Aakash can explore it. :)

@jonatanklosko jonatanklosko merged commit d8d52c9 into main Nov 9, 2021
@jonatanklosko jonatanklosko deleted the jk-runtimes branch November 9, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants