-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add current version section to settings page #851
Conversation
Hey @julngomz thanks for working on this! I think we should move the info as a subsection of "System settings", right below "File systems". Design wise, it would be neat to use the same styling that we use for file systems, so a box like this:
And the dashboard button would go in that box on the very end. You can reuse the styling from As for the shutdown button, @josevalim will add it separately, so I'd ignore it for now. |
Quick amendment: let's have it above file systems. It should be the first subsection. :) |
Did a couple adjustments, thanks @julngomz! |
<h4> | ||
<%= case field do %> | ||
<% :version -> %> | ||
<%= Mix.Project.config[:version] %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A heads up: we shouldn't use Mix.Project
inside lib because Mix
is not available in releases. I will push a fix shortly. :)
Issue
Add dashboard button to settings #849
Changes
Add the Current Version section to the Settings page with two buttons for shutdown (stays on the current page) and patching in the dashboard.