-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a bit of contrast to the comments in the code editor #859
Adds a bit of contrast to the comments in the code editor #859
Conversation
98cd25e
to
30d94d2
Compare
assets/js/cell/live_editor/theme.js
Outdated
@@ -4,7 +4,7 @@ const colors = { | |||
default: "#abb2bf", | |||
lightRed: "#e06c75", | |||
blue: "#61afef", | |||
gray: "#5c6370", | |||
gray: "#737A8C", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gray: "#737A8C", | |
gray: "#737a8c", |
assets/css/ansi.css
Outdated
@@ -14,7 +14,7 @@ to be consistent with the editor. | |||
--ansi-color-magenta: #c678dd; | |||
--ansi-color-cyan: #56b6c2; | |||
--ansi-color-white: white; | |||
--ansi-color-light-black: #5c6370; | |||
--ansi-color-light-black: #737a8c; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This font is used on white background I think. Are we sure we want to change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cristineguadelupe i think the change you did to code comments was good, I think we should just use two different shades of gray. One for comments, another for ansi. :) |
With the current color, the comments are almost unreadable. A little more contrast while keeping the same shade of gray increases readability without losing the consistency of the theme.