-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove --open-new option when starting liveserver #960
Conversation
FWIW, the commit history issue is because you did your work on main. Once this is merged, I recommend deleting and starting a new fork and doing your work on branches. :) |
💚 💙 💜 💛 ❤️ |
@@ -15,12 +15,20 @@ defmodule LivebookCLI.Server do | |||
@impl true | |||
def usage() do | |||
""" | |||
Usage: livebook server [url] [options] | |||
Usage: livebook server [open-command] [--options] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josevalim what about livebook server [options] [open-command]
?
I think it's more common to list options first. Also --options
looks like it was an actual option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change!
Refers to #950 (specifically point 1 of this comment)
Note. (Git history seems a bit messed, while it's already rebased)