Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent deprecation warnings from exporting an invalid image binary #77

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Prevent deprecation warnings from exporting an invalid image binary #77

merged 1 commit into from
Apr 10, 2024

Conversation

jonatanklosko
Copy link
Member

Closes #76.

cristineguadelupe
cristineguadelupe approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@cristineguadelupe cristineguadelupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

@jonatanklosko jonatanklosko merged commit 64c6a89 into main Apr 10, 2024
2 checks passed
@jonatanklosko jonatanklosko deleted the jk-export-warnings branch April 10, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristineguadelupe cristineguadelupe cristineguadelupe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vega.Export.save!() function generates invalid images for PNG and SVG
2 participants
@jonatanklosko @cristineguadelupe