AA-13801 Create no-declare rule to prevent using declare keyword
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norbertprocak
force-pushed
the
feature/AA-13801
branch
from
5edd0ed to
e9bb868
Compare
package.json
Outdated
| @@ -0,0 +1,40 @@ | |||
| { | |||
| "name": "@livechat/eslint-plugin", | |||
| "version": "0.1.7", | |||
There was a problem hiding this comment.
Why such a strange version? Shouldn't we start with 1.0.0?
There was a problem hiding this comment.
it's my working version, I will replace it with 1.0.0 when task is ready to merge
AlithAnar
reviewed
Aug 5, 2022
src/rules/no-declare.ts
Outdated
| create(context, [options]) { | ||
| const { onlyIdentifiers, excludeIdentifiers } = options; | ||
| const onlyIdentifiersEnabled = | ||
| onlyIdentifiers && onlyIdentifiers?.length > 0; |
There was a problem hiding this comment.
Suggested change
| onlyIdentifiers && onlyIdentifiers?.length > 0; | |
| !!onlyIdentifiers?.length; |
src/rules/no-declare.ts
Outdated
| const onlyIdentifiersEnabled = | ||
| onlyIdentifiers && onlyIdentifiers?.length > 0; | ||
| const excludeIdentifiersEnabled = | ||
| excludeIdentifiers && excludeIdentifiers.length > 0; |
src/rules/no-declare.ts
Outdated
|
|
||
| return { | ||
| VariableDeclaration(node) { | ||
| if (node.declare) { |
There was a problem hiding this comment.
Suggested change
| if (node.declare) { | |
| if (!node.declare) { | |
| return | |
| } |
mreszke
approved these changes
Aug 5, 2022
…> CR > return early
…> CR > More readable checks
dawid-drelichowski
approved these changes
Aug 5, 2022
AlithAnar
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://livechatinc.atlassian.net/browse/AA-13801