Add support for validations #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +40,10 @@ class Base | |||
| # so it needs to be included last. | |||
| include Dirty | |||
|
|
|||
| # Overrides persistence methods, so it must included after | |||
| include Validations | |||
There was a problem hiding this comment.
Does including this after Dirty cause any issues with the dirty tracking?
There was a problem hiding this comment.
After looking at the Validations module, this shouldn't be an issue since it calls super. However, if there are not specs around this already, it might a good idea to add some to verify.
There was a problem hiding this comment.
It can go before or after Dirty, but it must be after Persistence
|
Looks good. |
|
Released in v2.2.0. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wires up ActiveModel::Validations to run when calling
saveandsave!, in the same way that active record does it.This also includes ActiveModel::Validations::Callbacks which will add
before_validation,after_validation, etc.