Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ruby-3.1 compatibility #97

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

skunkworker
Copy link
Collaborator

@skunkworker skunkworker commented Jun 6, 2024

Specs work on:

Jruby 9.3/9.4
CRuby 2.7/3.0/3.1

after the arguments change.

@skunkworker skunkworker changed the title added ruby-3.1 compatability added ruby-3.1 compatibility Jun 6, 2024
@skunkworker
Copy link
Collaborator Author

I'll get multiple rails support testing up soon.

@liveh2o liveh2o merged commit d4453ec into liveh2o:master Jun 9, 2024
@liveh2o
Copy link
Owner

liveh2o commented Jun 9, 2024

Released in v7.0.0.

@liveh2o
Copy link
Owner

liveh2o commented Jun 9, 2024

I'm guessing merging this and #96 changed something because actions are now failing... 🤔

@skunkworker
Copy link
Collaborator Author

@liveh2o I think we need to make a separate 6-1-stable branch with includes Ruby 3.1 support. As the newest Rails 7 release is pinned pessimistically to ~> 7.0. And I am currently in the process of taking a Rails 6.1 app to JRuby-9.4 (3.1 syntax) and there is no version that supports that at this time.

@liveh2o
Copy link
Owner

liveh2o commented Jun 15, 2024

@liveh2o I think we need to make a separate 6-1-stable branch with includes Ruby 3.1 support. As the newest Rails 7 release is pinned pessimistically to ~> 7.0. And I am currently in the process of taking a Rails 6.1 app to JRuby-9.4 (3.1 syntax) and there is no version that supports that at this time.

Ah, I see. I backported this change to v6.1.2. Specs pass under Ruby 2.7, so we should be good to go. Let me know if you have issues.

@liveh2o
Copy link
Owner

liveh2o commented Jun 16, 2024

I also backported this change to v6.0.3 even though Rails 6.0 is EOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants