Ensure listeners are firing after multiple tracks have unsubscribed

We were pre-emptively removing Unsubscribed event listeners for all future unsubscribed events.
livekit · Jan 4, 2022 · 8587af6 · 8587af6
1 parent 26c01b3
commit 8587af6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/room/participant/RemoteParticipant.ts b/src/room/participant/RemoteParticipant.ts
@@ -136,7 +136,6 @@ export default class RemoteParticipant extends Participant {
         publication.track = undefined;
       }
       this.emit(ParticipantEvent.TrackUnsubscribed, track, publication);
-      this.removeAllListeners(ParticipantEvent.TrackUnsubscribed);
     };
     this.emit(ParticipantEvent.TrackSubscribed, track, publication);
 
@@ -229,7 +228,6 @@ export default class RemoteParticipant extends Participant {
       // always send unsubscribed, since apps may rely on this
       if (isSubscribed) {
         this.emit(ParticipantEvent.TrackUnsubscribed, track, publication);
-        this.removeAllListeners(ParticipantEvent.TrackUnsubscribed);
       }
     }
     if (sendUnpublish) { this.emit(ParticipantEvent.TrackUnpublished, publication); }

diff --git a/src/room/track/RemoteTrackPublication.ts b/src/room/track/RemoteTrackPublication.ts
@@ -31,6 +31,7 @@ export default class RemoteTrackPublication extends TrackPublication {
     const sub: UpdateSubscription = {
       trackSids: [this.trackSid],
       subscribe: this.subscribed,
+      participantTracks: [],
     };
     this.emit(TrackEvent.UpdateSubscription, sub);
   }