Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use legacy SVC encoding specification for React-Native #1093

Merged
merged 3 commits into from
May 31, 2024
Merged

Conversation

davidzhao
Copy link
Member

Even tho RN runs M114, it does not produce SVC layers when a single encoding is provided.
So we'll use the legacy SVC specification for now.

Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: b371b79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 27, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 82.29 KB (+0.01% 🔺)
dist/livekit-client.umd.js 87.82 KB (+0.01% 🔺)

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidliu
Copy link
Contributor

davidliu commented Apr 3, 2024

Whoops, missed this PR. Will run tests tomorrow.

Copy link
Contributor

@davidliu davidliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and creates the extra layers with the patch.

@lukasIO lukasIO merged commit 0d919c6 into main May 31, 2024
3 checks passed
@lukasIO lukasIO deleted the rn-spatial-spec branch May 31, 2024 09:15
@github-actions github-actions bot mentioned this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants