Correct track replacement when resuming local track upstream #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This should prevent replacing the processed track with the unprocessed track, if a track processor was applied while the track upstream was paused.
🦋 Changeset detectedLatest commit: dda287b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasIO
approved these changes
Jun 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a track processor is applied to a video track while the track's upstream is paused (ie.
pauseUpstream()has been called on it), the next call to resume upstream will replace the processed track with the plain, unprocessed track. This should correct that logic and prevent this incorrect replacement.My app was performing the following steps when I ran into this behavior:
I am pausing and resuming the track when I am making processor changes to prevent showing any "flashes" of unprocessed frames when changing between virtual background options.