Use ReturnTypes of built-in functions for critical timers #1236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported an issue where they were running into a typescript compile error due to
NodeJS.Timer
being declared intimers.d.ts
.This is due to the fact that some of the client-sdk-js dependencies rely on
@types/node
which leads to thesetTimeout
andsetInterval
return types to be interpreted for NodeJS at build time.In order to avoid this, we manually declare the types as
ReturnType
of said functions which will prevent references toNodeJS
types in the build output.