-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support react native #167
Support react native #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! could you install eslint in VS Code and take a look at the lint failures?
import Queue from './RequestQueue'; | ||
|
||
if (isWeb()) { | ||
import('webrtc-adapter'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dynamic import is the main thing I'm unsure about. The webrtc-adapter library has a bunch of web specific code that crashes on react native, so needs to be omitted for RN. Didn't run into any issues on Chrome, but if there's a more proper way to do this, I'm all ears.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if there's a better way.. will test this for safari and FF to ensure things are still working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirming it works on FF/Safari too.
No description provided.