-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vp9 support for E2EE #836
Conversation
🦋 Changeset detectedLatest commit: 708003f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
closing for now due to the backupCodec complications |
Could you elaborate a little bit? I'd still consider this open, as VP9 support is still wanted and missing. |
hi @Stogas, encryption support for backup codecs is missing, which would be needed to ensure that also clients that don't support vp9 would be able to receive the media stream. I can reopen the issue, but there's currently no ETA for encryption support of backup codecs |
We should disable backupCodec when e2ee is used. since vp9 is supported everywhere, I think the impact of that should be fairly minimal |
That's what we do already today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
Unfortunately av1 fails with
TypeError: Destination stream closed
when trying to decode frames. This needs further investigation.Until then, VP9 addition is nice, too!
~~Caveats: this is currently only secure if
backupCodec: undefined
is specified. Backup codecs are currently sent unencrypted, which is definitely unexpected. ~~^ backup codecs are currently disabled in general when e2ee is enabled