Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vp9 support for E2EE #836

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Add vp9 support for E2EE #836

merged 4 commits into from
Jul 8, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Aug 14, 2023

Unfortunately av1 fails with TypeError: Destination stream closed when trying to decode frames. This needs further investigation.
Until then, VP9 addition is nice, too!

~~Caveats: this is currently only secure if backupCodec: undefined is specified. Backup codecs are currently sent unencrypted, which is definitely unexpected. ~~
^ backup codecs are currently disabled in general when e2ee is enabled

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

🦋 Changeset detected

Latest commit: 708003f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested a review from davidzhao August 14, 2023 15:15
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 80.24 KB (0%)
dist/livekit-client.umd.js 86.06 KB (0%)

@lukasIO
Copy link
Contributor Author

lukasIO commented Aug 15, 2023

closing for now due to the backupCodec complications

@lukasIO lukasIO closed this Aug 15, 2023
@Stogas
Copy link

Stogas commented Jul 2, 2024

@lukasIO

Could you elaborate a little bit?

I'd still consider this open, as VP9 support is still wanted and missing.

@lukasIO
Copy link
Contributor Author

lukasIO commented Jul 4, 2024

hi @Stogas,

encryption support for backup codecs is missing, which would be needed to ensure that also clients that don't support vp9 would be able to receive the media stream.

I can reopen the issue, but there's currently no ETA for encryption support of backup codecs

@lukasIO lukasIO reopened this Jul 4, 2024
@davidzhao
Copy link
Member

We should disable backupCodec when e2ee is used. since vp9 is supported everywhere, I think the impact of that should be fairly minimal

@lukasIO
Copy link
Contributor Author

lukasIO commented Jul 5, 2024

We should disable backupCodec when e2ee is used.

That's what we do already today.
I'll update this PR in order to merge it in

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@lukasIO lukasIO merged commit dcf0374 into main Jul 8, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/vp9-e2ee-support branch July 8, 2024 07:43
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants