pm: return error from validateTicketParams() if ticket params is nil

livepeer · Mar 26, 2021 · af682a3 · af682a3
1 parent d8c8f50
commit af682a3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/pm/sender.go b/pm/sender.go
@@ -146,6 +146,10 @@ func (s *sender) ValidateTicketParams(ticketParams *TicketParams) error {
 
 // validateTicketParams checks if ticket params are acceptable for a specific number of tickets
 func (s *sender) validateTicketParams(ticketParams *TicketParams, numTickets int) error {
+	if ticketParams == nil {
+		return fmt.Errorf("ticketParams is nil")
+	}
+
 	if ticketParams.ExpirationBlock.Int64() == 0 {
 		return nil
 	}

diff --git a/pm/sender_test.go b/pm/sender_test.go
@@ -428,6 +428,11 @@ func TestCreateTicketBatch_ConcurrentCallsForSameSession_SenderNonceIncrementsCo
 	assert.Equal(totalTickets, len(uniqueNonces))
 }
 
+func TestValidateTicketParams_NilTicketParams_ReturnsError(t *testing.T) {
+	sender := defaultSender(t)
+	assert.EqualError(t, sender.validateTicketParams(nil, 1), "ticketParams is nil")
+}
+
 func TestValidateParams_ValidateSender(t *testing.T) {
 	sender := defaultSender(t)
 	sm := sender.senderManager.(*stubSenderManager)