Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/livepeer_bench: live mode, better stats #1778

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Conversation

jailuthra
Copy link
Contributor

What does this pull request do? Explain your changes. (required)

Add option to simulate live-mode in the benchmarking tool. Also, clean up the output statistics to show real-time segment ratio and stream duration ratio.

Specific updates (required)

  • Adds an option to enable live-mode, which would wait to transcode segments based on their duration in the input playlist.
  • Improve output statistics

How did you test each of these updates (required)

Manual testing with ./livepeer_bench -in ~/Videos/bbb/source.m3u8 -outPrefix /tmp/out -nvidia 0 -concurrentSessions 20 -transcodingOptions cmd/livepeer_bench/transcodingOptions.json -segs 20

Does this pull request close any open issues?

Fixes #1699

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

cmd/livepeer_bench/livepeer_bench.go Outdated Show resolved Hide resolved
{"Concurrent Sessions", fmt.Sprintf("%v", *concurrentSessions)},
{"Total Segs Transcoded", fmt.Sprintf("%v", segCount)},
{"Real-Time Segs Transcoded", fmt.Sprintf("%v", realTimeSegCount)},
{"* Real-Time Segs Ratio *", fmt.Sprintf("%0.4v", float64(realTimeSegCount)/float64(segCount))},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why asterisks are added here? Anything particularly special about this stat relative to the other ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to highlight this and Real-Time Duration Ratio in some manner - as a user I would personally be most interested in quickly eyeballing these two ratios. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Sounds reasonable.

cmd/livepeer_bench/livepeer_bench.go Show resolved Hide resolved
cmd/livepeer_bench/livepeer_bench.go Outdated Show resolved Hide resolved
@jailuthra jailuthra requested a review from yondonfu March 1, 2021 23:06
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after squashing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add live mode to livepeer_bench
2 participants